Add server_status message to the raft peering service #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farost
commented
Jul 11, 2025
| message Res { | ||
| // TODO: Currently, it's identical to Server. But it won't necessarily be the case forever, so these fields are | ||
| // split. Additionally, we want to highlight that the address is the connection address. | ||
| // TODO: We may move ReplicaStatus somewhere else now... |
There was a problem hiding this comment.
These todos are more like PR comments. I think it's fine as is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: usage and product changes
Add server_status message to the raft peering service and rename the old raft peering messages to adjust to the existing naming conventions.
Implementation